Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore namespace after regress. Fixes #2474 #2524

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Restore namespace after regress. Fixes #2474 #2524

merged 1 commit into from
Jan 31, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jan 30, 2020 •
edited
Loading

Description
MigrationRunner::regress() wipes the current namespace so findMigrations() will load ALL migration files. This has the unintended side effect of causing subsequent runs to lack an assumed preset namespace.

This PR stashes the namespace and restores it post-regression.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner merged commit d6ed858 into codeigniter4:develop Jan 31, 2020
@MGatner MGatner deleted the migration-namespace branch November 8, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MGatner